Allow add-machine to take a -n param

[mattyw]

Fix for https://bugs.launchpad.net/juju-core/+bug/1214209

Allow add-machine to take a -n param to add multiple machines

[axw]

I think you meant https://bugs.launchpad.net/juju-core/+bug/1214209

This needs some tweaking to take into account placement. I think if if the user specifies -n, then they probably shouldn't be allowed to specify a placement directive (just as in juju deploy).

[mattyw]

@axw ptal

[axw]

This won't work. "lxc" is a placement directive.

EDIT: ah, I see what you did now. Never mind.

[axw]

I think we could do with better error reporting, but otherwise I'm happy with this.

[mattyw]

@axw thanks for the feedback, the output is much better now, ptal

[axw]

I'm +1 on returning the original error if there's only one failure, but I think we need to be consistent with the error output.

I think it might be better just to print out the "failed to create N machine(s)" regardless of how many there are, and then return cmd.ErrSilent. Also, I think you want to be printing to ctx.Stderr() for errors -- they shouldn't be hidden by -q IMO.

[axw]

Thanks. Nearly there, just would like the error output to be consistent between the single/multi error case.

[mattyw]

@axw thanks for the feedback, ptal
Changes:

• Single and multiple modes now print "failed to create 1/n machine/machines
• The failed to create message is sent to stderr
• In multiple failures the error message is joined with "," and printed in a single line. I experimented with other ways of displaying it but none of them appeared great in the log. The current version has the potential for long error lines but looks better than \n in my opinion

[axw]

Thanks! LGTM

[mattyw]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju