state server upgrade sync refactoring #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -172,131 +192,84 @@ func (c *upgradeWorkerContext) run(stop <-chan struct{}) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (c *upgradeWorkerContext) initTag(tag names.Tag) error { | |||
There was a problem hiding this comment.
why not change the type of the argument to names.MachineTag then it's the callers problem to pass the right value
There was a problem hiding this comment.
Hmm... the main point of the method is the type assertion...
|
I like the refactoring into separate methods. LGTM |
added 2 commits
September 15, 2014 12:24
1. Use version.Number's in logs and status output throughout instead of version.Binary's. The series and architecture is irrelevant to the upgrade process and including it just adds unnecessary verbosity. 2. The check for an already completed upgrade has been moved earlier to avoid unnecessary initialisation. 3. New upgradeWorkerContext attributes have been added to make the from version more accessible and the target version shorter to read and write.
This revision is primarily about splitting up runUpgrades into smaller pieces. This function was getting to be too large and difficult to follow.
mjs
force-pushed
the
upgrade-sync-refactoring
branch
from
1f46900
to
b1a6bd2
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 15, 2014
state server upgrade sync refactoring Various clean ups for the recent state server upgrade synchronisation work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various clean ups for the recent state server upgrade synchronisation work.