Refactor the UserManager and commands. #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howbazaar
force-pushed
the
user-manager-tag-redux
branch
from
0491f68
to
6220a75
Compare
This branch adds consistency to the UserManager. Primarily around the use of tags to pass the usernames. Also untangles the API client from the server that was there with the user manager structs being defined in the apiserver package (not params). The commands have been hooked up, and tested manually. There were several clear changes needed when testing: * until we have multiple environments, creating a user should cause that user to have access to the environment * when adding a user, we should always write out the jenv file (until the user is able to login and see themselves) * the remove user command has been renamed to disable, as it wasn't removing the user at all (this is still todo)
Deactivated renamed throughout. Client side user manager now deals in strings. Commands moved into user directory.
howbazaar
force-pushed
the
user-manager-tag-redux
branch
from
6220a75
to
bee6eab
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Oct 22, 2014
Refactor the UserManager and commands. This branch adds consistency to the UserManager. Primarily around the use of tags to pass the usernames. Also untangles the API client from the server that was there with the user manager structs being defined in the apiserver package (not params). The commands have been hooked up, and tested manually. There were several clear changes needed when testing: * until we have multiple environments, creating a user should cause that user to have access to the environment * when adding a user, we should always write out the jenv file (until the user is able to login and see themselves) * the remove user command has been renamed to disable, as it wasn't removing the user at all (this is still todo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds consistency to the UserManager.
Primarily around the use of tags to pass the usernames.
Also untangles the API client from the server that was
there with the user manager structs being defined in the
apiserver package (not params).
The commands have been hooked up, and tested manually.
There were several clear changes needed when testing:
should cause that user to have access to the environment
file (until the user is able to login and see themselves)
as it wasn't removing the user at all (this is still todo)