Update trim stage to default to shorter queues. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed the txn commit code to refuse if the queue is longer than 1000. However, we only trim down to 1000, so the resume stage ends up having no room to work. This way we trim the queue down smaller, and give a knob in case we find we're doing it wrong.
This allows us to build using 'snapcraft' again. It isn't perfect, but it is a step in the right direction. Note that mgpurge can only be built using go 1.12 right now (1.13 complains about a missing main function.) Ideally we would get off of GB entirely, and just use go.mod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the txn commit code to refuse if the queue is longer than
1000. However, we only trim down to 1000, so the resume stage ends up
having no room to work. This way we trim the queue down smaller, and
give a knob in case we find we're doing it wrong.