names: NewActionTag must panic if the action tag is not valid #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contract of the NewXXXTag methods is they should return a valid names.Tag impl or they should panic. As these functions are called almost exclusively in tests to create fixtures, this black and white pattern is appropriate. This PR changes names.NewActionTag to the expected behavior and adds tests to assert this same.
|
LGTM |
howbazaar
added a commit
that referenced
this pull request
Jul 21, 2014
names: NewActionTag must panic if the action tag is not valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract of the NewXXXTag methods is they should return a valid names.Tag impl or they should panic. As these functions are called almost exclusively in tests to create fixtures, this black and white pattern is appropriate.
This PR changes names.NewActionTag to the expected behavior and adds tests to assert this same.