Refactor ParseTag #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davecheney
commented
Jun 16, 2014
davecheney
commented
- refactor ParseTag, removing the hint. The hint was only used by code when it expected a specific tag type.
- introduce type specific Tag parsers, these replace all the uses of ParseTag with hint, and return a specific Tag implementation, not an interface.
- Add unit tests for new methods
* refactor ParseTag, removing the hint. The hint was only used by code when it expected a specific tag type. * introduce type specific Tag parsers, these replace all the uses of ParseTag with hint and return a specific Tag implementation, not an interface, so the Tag's implemenations values are available without calling a helper method * Add unit tests for new methods
* refactor ParseTag, removing the hint. The hint was only used by code when it expected a specific tag type. * introduce type specific Tag parsers, these replace all the uses of ParseTag with hint and return a specific Tag implementation, not an interface, so the Tag's implemenations values are available without calling a helper method * Add unit tests for new methods
…/names into 106-parsetag-refactor
| tag: "", | ||
| err: names.InvalidTagError("", ""), | ||
| }, { | ||
| tag: "machine-0", |
There was a problem hiding this comment.
this is a gofmt bug, http://code.google.com/p/go/issues/detail?id=8215
|
Done. |
|
PTAL. I tweaked the example, but that was all I changed. |
|
If the Parse functions are going to return specific tag types, shouldn't the New* functions do likewise? |
|
They can do that, I can address that in a followup branch. On Mon, Jun 16, 2014 at 5:31 PM, rogpeppe notifications@github.com wrote:
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.