Ask for credentials if some missing before connect

Fixes #1001
juju · Feb 7, 2024 · e203dd7 · e203dd7
1 parent 2154a9e
commit e203dd7
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/juju/client/connector.py b/juju/client/connector.py
@@ -94,6 +94,9 @@ async def connect(self, **kwargs):
             if 'password' not in kwargs and account.get('password'):
                 kwargs.update(password=account.get('password'))
 
+            if not ({'username', 'password'}.issubset(kwargs)):
+                required = {'username', 'password'}.difference(kwargs)
+                raise ValueError(f'Some authentication parameters are required : {",".join(required)}')
             self._connection = await Connection.connect(**kwargs)
 
         # Check if we support the target controller