BundleHandler uses GetChangesMapArgs when available #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following commit ensures that we use the latest bundle api facade changes call. This cleans up the problem of what to use in terms of bundle changes, shame pylib juju is now ahead of golang cli :D - Move bundle client facade to v4
As part of the update, we should keep updating the schema from the API server.
SimonRichardson
commented
Sep 5, 2019
| @@ -28,7 +28,7 @@ | |||
| 'ApplicationScaler': {'versions': [1]}, | |||
| 'Backups': {'versions': [1, 2]}, | |||
| 'Block': {'versions': [2]}, | |||
| 'Bundle': {'versions': [1, 2, 3]}, | |||
| 'Bundle': {'versions': [1, 2, 3, 4]}, | |||
There was a problem hiding this comment.
Change the bundle facade from 3 to 4.
SimonRichardson
commented
Sep 5, 2019
| yaml=yaml.dump(self.bundle)) | ||
| else: | ||
| log.info("bundle_facade using GetChangesMapArgs API to deploy bundle changes") | ||
| self.plan = await self.bundle_facade.GetChangesMapArgs( |
There was a problem hiding this comment.
Use the latest method if it's available
achilleasa
approved these changes
Sep 5, 2019
| @@ -3,20 +3,20 @@ | |||
|
|
|||
| from juju.client._definitions import * | |||
|
|
|||
| from juju.client import _client1, _client2, _client3, _client4, _client5, _client6, _client7, _client8, _client9, _client10, _client12 | |||
| from juju.client import _client2, _client1, _client3, _client4, _client5, _client8, _client7, _client9, _client10, _client6, _client12 | |||
There was a problem hiding this comment.
Is the ordering intentional to mess with people that have OCD? ;-)
There was a problem hiding this comment.
I'm triggered EVERYTIME... I might work out why it does this.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR updates the BundleHandler code to use
GetChangesMapArgsfrom Juju when possible. Additionally also updated the schema to have the latest 2.7-dev schema.QA
Ensure you have the following branch checked out juju/juju#10601, or if it's merged, use develop branch.
Deploy the branch so we can test against it:
juju bootstrap lxd test --no-gui --build-agentTo ensure that we're using the right method call, change the following:
Then run:
You should see in the output of the example: