Unknown facade #382
Merged
Unknown facade #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitechie
approved these changes
Jan 9, 2020
|
|
The following changes how we handle future compatibility. In an effort to improve compatibility with Juju and it's clients. Previously the client would attempt to negotiate every facade that Juju would have ever released, which allows backwards compatibility but not forward. With the following changes we're essentially unrestricting forward compatibility. Allowing the client to speak to future Juju's even if the facade version isn't known. We warn the user as much as possible about the missing facade version, before ignoring it and allowing accessing to be done. In reality this means if you try and access a facade that doesn't exist in the library, but does in Juju, it won't work.
SimonRichardson
force-pushed
the
unknown-facade-version
branch
from
c620979
to
0fb546d
Compare
|
|
This was referenced May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes how we handle future compatibility. In an effort
to improve compatibility with Juju and it's clients. Previously the
client would attempt to negotiate every facade that Juju would have ever
released, which allows backwards compatibility but not forward.
With the following changes we're essentially unrestricting forward
compatibility. Allowing the client to speak to future Juju's even if the
facade version isn't known.
We warn the user as much as possible about the missing facade version,
before ignoring it and allowing accessing to be done.
In reality this means if you try and access a facade that doesn't exist
in the library, but does in Juju, it won't work.