Possible solution for unit run inconsistencies #711

addyess · 2022-08-12T14:12:47Z

I agree there's inconsistency from the juju api response there. Since action.wait() ultimately just fills out the results dict more, what we we add some decode logic to the Action object to handle the various facades?

Action could have an attribute that returned an object like subprocess.CompletedProcess[https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess]

users of the unit.run class could do this:

    response = await unit.run(cmd)
    response.completed.check_returncode()  # raises a known exception for non-zero return codes
    stdout = response.completed.stdout

juju#707 I agree there's inconsistency from the juju api response there. Since `action.wait()` ultimately just fills out the `results` dict more, what we we add some decode logic to the `Action` object to handle the various facades? Action could have an attribute that returned an object like `subprocess.CompletedProcess`[https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess] users of the unit.run class could do this: ```python response = await unit.run(cmd) response.completed.check_returncode() # raises a known exception for non-zero return codes stdout = response.completed.stdout ```

jujubot · 2022-08-12T14:12:49Z