Add base.bootstrapped decorator to integration test #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which allows to test to skip (instead of failing) if there's no bootstrapped juju in the environment (which we don't in the merge jobs in jenkins). Looks like we accidentally took it out in juju@5b55b35#diff-9405e0bc34a26ab57891171003bb7253b44c20fa921670f44b207c1971b413f1
SimonRichardson
approved these changes
May 17, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like we accidentally took out a useful decorator in 5b55b35
The
base.bootstrappedallows to test to skip (instead of failing) if there's no bootstrapped juju in the environment (which we don't in the merge jobs in jenkins).QA Steps
All CI tests need to pass.
The
github-check-merge-juju-python-libjujujob fails without this, so that job should be passing.Notes & Discussion
#853 should rebase on
masterafter this lands.