Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-3887] Avoid removing the track if set to latest in channel normalization #867

Merged
merged 2 commits into from May 31, 2023

Conversation

cderici
Copy link
Member

@cderici cderici commented May 30, 2023

Description

This is essentially a backport of a fix we already have in the master branch. In the past we used to remove the latest track from the origin channel as part of the normalization even if it's set by the user via the --channel flag. Now we're passing it through into the ResolveCharm.

Fixes #863

QA Steps

We can directly use the scenario in #863

python -m asyncio
asyncio REPL 3.10.6 (main, Mar 10 2023, 10:55:28) [GCC 11.3.0] on linux
Use "await" directly instead of "asyncio.run()".
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
>>> from juju import model; m=model.Model(); await m.connect();await m.deploy("postgresql-k8s",series="focal", channel="latest/stable")
<Application entity_id="postgresql-k8s">
>>>

Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

I have checked and this is already in 3.1 and master branches.

@juanmanuel-tirado juanmanuel-tirado merged commit e9eb197 into juju:2.9 May 31, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants