ObjMethod: Always pass context.Context for API method calls #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All API server calls make passing context.Context optional. This means that most if not all API requests do not utilise the context available to them. This means that it makes it a lot hard to know when a request should be cancelled or discarded. This will become really useful when migrating a way from mongo and to another database store. Additionally we can start to hang more things from the context allow them to pass through the stack. This is a breaking change, by forcing context.Context to become non-optional and forcing juju to handle context correctly.
manadart
approved these changes
Dec 12, 2022
|
I'm in favor of this, though I wonder if we are better off having context.Context mean something on the juju side. Otherwise you have the idea that it is 'cancelable' but nobody is actually listening on the other side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All API server calls make passing context.Context optional. This means that most if not all API requests do not utilise the context available to them. This means that it makes it a lot hard to know when a request should be cancelled or discarded.
This will become really useful when migrating a way from mongo and to another database store. Additionally we can start to hang more things from the context allow them to pass through the stack.
This is a breaking change, by forcing context.Context to become non-optional and forcing juju to handle context correctly.