Use DeployFromRepository when possible.

[hmlanigan]

Description

If the controller has implemented the Application facade of version 19 or higher, use DeployFromRepository method to deploy a charm. This method shortcuts most of the deploy business logic in the client and allows the controller to handle it all.

To handle shared input manipulation between the 2 methods, created a new input struct with a parse() method.

Type of change

• Logic changes in resources (the API interaction with Juju has been changed)

Environment

• Juju controller version: 2.9.47, 3.3.1

• Terraform version: any

QA steps

Run the following plan against a 2.9.47 controller and against a 3.3.1 controller with debug enabled, export TF_LOG_PROVIDER=TRACE ; export TF_LOG_PATH=./terraform.log.

Against 2.9.47, you should find the debug line "Calling Deploy". Against 3.3.1, you should find the debug line "Calling DeployFromRepository".

terraform {
  required_providers {
    juju = {
      version = ">= 0.11.0"
      source  = "juju/juju"
    }
  }
}

provider "juju" {
}

resource "juju_model" "one" {
  name = "unit-test"
}

resource "juju_application" "app-a" {
  model = juju_model.one.name
  charm {
    name = "juju-qa-test"
  }
}

resource "juju_application" "app-b" {
  model = juju_model.one.name
  charm {
    name = "jameinel-ubuntu-lite"
  }
}

Also run

Additional notes

JUJU-5429

[anvial]

@hmlanigan, I successfully passed QA on 2.9.47,

But on 3.3.1 I faced the following error:

juju_model.one: Creating...
╷
│ Error: Client Error
│
│   with juju_model.one,
│   on plan.tf line 13, in resource "juju_model" "one":
│   13: resource "juju_model" "one" {
│
│ Unable to create model, got error: interface conversion: interface {} is nil, not string
╵

[anvial]

DeployFromRepository

It sorted out that was my problem of "not removing the previous version of the plugin".

[anvial]

QA passed, I'm ok with code

[hmlanigan]

2.9 tests have expected failure of "Unable to create model, got error: juju client with version 3.3 used with a
controller having major version 2 not supported"