Make auth in MgoSuite optional, disabled by default #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Juju tests mostly don't care about authentication. By disabling authentication by default, segregating the tests that do care (i.e. explicit checks for authentication/authorisation) and enabling authentication for them, then we can easily run with either Mongo 2.4 or 2.6 despite the changes made to security between the versions.
|
LGTM |
axw
added a commit
that referenced
this pull request
Aug 14, 2014
Make auth in MgoSuite optional, disabled by default
jujubot
added a commit
to juju/juju
that referenced
this pull request
Aug 14, 2014
Various changes to support Mongo 2.6 Disable auth in Mongo for all except a handful of tests, which we segregate and enable authentication for explicitly. Ignore all commits other than 326c231: this builds on top of PR #498. Requires juju/testing#28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Juju tests mostly don't care about authentication.
By disabling authentication by default, segregating
the tests that do care (i.e. explicit checks for
authentication/authorisation) and enabling authentication
for them, then we can easily run with either Mongo 2.4 or
2.6 despite the changes made to security between the
versions.