Turns out it isn't safe to use aggregation in 2.4 at all. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.4 fails if the total size of the aggregation is too big, while in 3.2 it only fails if the size of an individual doc gets too big. Running mgopurge against big 2.4 databases was failing (2.4M txns * 20 bytes per ID is >16MB).
|
|
jujubot
added a commit
to juju/juju
that referenced
this pull request
Apr 27, 2017
use latest juju/txn ## Description of change When running mgopurge against older Juju repositories, we found it doesn't do well with very large (2M+) txn collections on mongo 2.4. This brings in the fix for that. Its my understanding that Juju controllers on Trusty still use Mongo 2.4. ## QA steps Running Juju against Mongo 2.4 with very large txn collections should successfully prune the txn collection instead of getting an error about the aggregation document being too large. ## Documentation changes None ## Bug reference juju/txn reference issue: juju/txn#31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.4 fails if the total size of the aggregation is too big,
while in 3.2 it only fails if the size of an individual doc
gets too big.
Running mgopurge against big 2.4 databases was failing
(2.4M txns * 20 bytes per ID is >16MB).
We already switched to just loading them one-by-one, it probably isn't much slower to use a Find() as we aren't doing anything fancy like $group.
(Review request: http://reviews.vapour.ws/r/6547/)