/utils

exec: don't use stdin to send commands to shell #134

Merged
merged 1 commit into from May 27, 2015
+63 −30

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@axw @jujubot
@axw
Member

axw commented May 26, 2015

Using stdin to send commands to the shell means that commands run with this cannot use stdin, or they will consume subsequent script input. Instead, write a temporary script file and keep it around until the process is Waited upon.

Tested on Linux and Windows.

(Review request: http://reviews.vapour.ws/r/1781/)
@axw
exec: don't use stdin to send commands to shell 
Using stdin to send commands to the shell means that
commands run with this cannot use stdin, or they will
consume subsequent script input. Instead, write a
temporary script file and keep it around until the
process is Waited upon.
9e634a6
@axw
Member

axw commented May 27, 2015

$$merge$$
@jujubot
Contributor

jujubot commented May 27, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils

jujubot added a commit that referenced this pull request May 27, 2015

@jujubot
Merge pull request #134 from axw/exec-no-stdin 
exec: don't use stdin to send commands to shell

Using stdin to send commands to the shell means that commands run with this cannot use stdin, or they will consume subsequent script input. Instead, write a temporary script file and keep it around until the process is Waited upon.

Tested on Linux and Windows.

(Review request: http://reviews.vapour.ws/r/1781/)
054b256

@jujubot jujubot merged commit 054b256 into juju:master May 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment