Move juju/cert pkg into utils. #250
Conversation
Signed-off-by: Salvatore Giulitti <sgiulitti@cloudbasesolutions.com>
|
|
||
| // NewCA generates a CA certificate/key pair suitable for signing server | ||
| // keys for an environment with the given name. | ||
| func NewCA(envName, UUID string, expiry time.Time) (certPEM, keyPEM string, err error) { |
There was a problem hiding this comment.
Since this is meant to be generic, I think we should just pass in the common name and use it directly in the CommonName field. juju/cert can then have its own NewCA function which calls the one in this package with fmt.Sprintf(...)
|
|
||
| // Verify verifies that the given server certificate is valid with | ||
| // respect to the given CA certificate at the given time. | ||
| func Verify(srvCertPEM, caCertPEM string, when time.Time) error { |
There was a problem hiding this comment.
unless this is needed by winrm, I think we should leave this one in juju/cert. It has some juju-specifics, because of the "anyServer".
There was a problem hiding this comment.
This is not needed for winrm, winrm itself has built it function to verify the cert.
| } | ||
|
|
||
| // newLeaf generates a certificate/key pair suitable for use by a leaf node. | ||
| func newLeaf(caCertPEM, caKeyPEM string, expiry time.Time, hostnames []string, extKeyUsage []x509.ExtKeyUsage) (certPEM, keyPEM string, err error) { |
There was a problem hiding this comment.
as above, I think this should take CommonName as an arg, and juju/cert can have its own version that passes in "*"
| return n, nil | ||
| } | ||
|
|
||
| // NewDefaultServer generates a certificate/key pair suitable for use by a server, with an |
There was a problem hiding this comment.
can we just keep these two functions (NewDefaultServer and NewServer) in juju/cert, and expose newLeaf (NewLeaf)?
There was a problem hiding this comment.
Yeah sure ! Sounds reasonable.
Signed-off-by: Salvatore Giulitti <sgiulitti@cloudbasesolutions.com>
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-utils |
Make all juju/cert paths point now to utils/cert This patch depends on this patch to be merged juju/utils#250 This patch contains: - moves juju/cert into utils/ pkg. - update code path for all files. - update dependencies.tsv
As discussed in here #249
@axw @dooferlad