Add Report method to the Runner #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiamac
reviewed
Aug 6, 2018
|
Adding some tests... |
howbazaar
force-pushed
the
runner-report
branch
from
576a77c
to
a96e025
Compare
howbazaar
force-pushed
the
runner-report
branch
from
a96e025
to
99f4bc1
Compare
|
!!build!! |
1 similar comment
|
!!build!! |
babbageclunk
approved these changes
Aug 6, 2018
| "state": info.status(), | ||
| } | ||
| if !info.started.IsZero() { | ||
| workerReport["started"] = info.started.Format("2006-01-02 15:04:05") |
There was a problem hiding this comment.
Ugh, the weird date formatting thing always throws me.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this work is to add a Report method to the Runner so we can see the nested reports in Juju for engines that nest runners.
As part of this work, I added the standard makefile and dependencies file. This highlighted licence mistakes, and to avoid bringing in juju/utils, just use juju/clock.