Feature: Persist disk granular space accounting #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwuensche
force-pushed
the
feature/disk-utilization-equalization
branch
from
e7b99ba
to
ab67573
Compare
jwuensche
changed the title
We should keep all msg prefix at one place to allow for some overview of them
jwuensche
force-pushed
the
feature/disk-utilization-equalization
branch
from
bd8008d
to
d462930
Compare
jwuensche
force-pushed
the
feature/disk-utilization-equalization
branch
from
d462930
to
aa022bf
Compare
Another identifier was introduced for the internal-api feature flag for this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two essential features, first it finalized space accounting previously introduced with #2 as it now also stores the disk space information in the root tree based on their 12bit global identifier. Second, this information is then used to start the Segment map search to find satisfying slots for the next allocation. This brings us a better scalability when not using Parity setups, second it allows for a more holistic overview of the current storage state, also helpful for user inspection.
In the process of this, we clean up the root tree keys by centralizing them in a separate module. Documentation for this is provided as module level documentation, easing the introduction of future keys.