Merge pull request #7 from DevFactory/release/multiple-code-improveme…

…nts-fix-1 Multiple code improvements - squid:UselessParenthesesCheck, squid:SwitchLastCaseIsDefaultCheck, squid:S1444
jpaulynice · Mar 7, 2016 · ca2da3a · ca2da3a
2 parents 490ed60 + baba59f
commit ca2da3a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/app/src/main/java/com/jigdraw/draw/activity/BaseJigsawActivity.java b/app/src/main/java/com/jigdraw/draw/activity/BaseJigsawActivity.java
@@ -48,6 +48,8 @@ public boolean onOptionsItemSelected(MenuItem item) {
                 startActivity(new Intent(getApplicationContext(),
                         JigsawHistoryActivity.class));
                 return true;
+            default:
+                break;
         }
         return false;
     }

diff --git a/app/src/main/java/com/jigdraw/draw/activity/DrawActivity.java b/app/src/main/java/com/jigdraw/draw/activity/DrawActivity.java
@@ -169,7 +169,7 @@ private void openNewDrawingDialog() {
                 .title(R.string.action_new_drawing)
                 .positiveText(R.string.action_ok)
                 .negativeText(R.string.action_cancel)
-                .content((R.string.action_new_q))
+                .content(R.string.action_new_q)
                 .show();
     }
 

diff --git a/app/src/main/java/com/jigdraw/draw/util/DBUtil.java b/app/src/main/java/com/jigdraw/draw/util/DBUtil.java
@@ -56,7 +56,7 @@ private DBUtil() {}
     public static final String ORIGINAL_SELECTION_NULL = "original is null";
 
     /** all columns selection */
-    public static String[] ALL_COLUMNS = new String[]{ID_COLUMN, NAME_COLUMN,
+    public final static String[] ALL_COLUMNS = new String[]{ID_COLUMN, NAME_COLUMN,
             IMAGE_COLUMN, DESC_COLUMN, ORIGINAL_COLUMN};
 
     /** arguments to set for the prepared statements */

diff --git a/app/src/main/java/com/jigdraw/draw/views/JigsawGridView.java b/app/src/main/java/com/jigdraw/draw/views/JigsawGridView.java
@@ -389,7 +389,7 @@ public int getPositionForID(long itemId) {
     }
 
     private OrderableAdapter getAdapterInterface() {
-        return ((OrderableAdapter) getAdapter());
+        return (OrderableAdapter) getAdapter();
     }
 
     private long getId(int position) {
@@ -578,7 +578,7 @@ private void handleCellSwitch() {
             View view = getViewForId(id);
             if (view != null) {
                 Point targetColumnRowPair = getColumnAndRowForView(view);
-                if ((aboveRight(targetColumnRowPair, mobileColumnRowPair)
+                if (aboveRight(targetColumnRowPair, mobileColumnRowPair)
                         && deltaYTotal < view.getBottom()
                         && deltaXTotal > view.getLeft()
                         || aboveLeft(targetColumnRowPair, mobileColumnRowPair)
@@ -601,7 +601,7 @@ private void handleCellSwitch() {
                         + mOverlapIfSwitchStraightLine || left(
                         targetColumnRowPair, mobileColumnRowPair)
                         && deltaXTotal < view.getRight()
-                        - mOverlapIfSwitchStraightLine)) {
+                        - mOverlapIfSwitchStraightLine) {
                     float xDiff = Math.abs(GridUtil.getViewX(view)
                             - GridUtil.getViewX(mMobileView));
                     float yDiff = Math.abs(GridUtil.getViewY(view)