This repository has been archived by the owner on Apr 23, 2018. It is now read-only.
added hide_mode option #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With hide_mode option the hide method for the dropdown can be changed to prevent different problems. "hide_mode: null": uses "'left': -9000" (its still the default to not break compatibility), can be problematic with very wide pages or with RTL. "hide_mode: display": uses display hide/block, should be the most performant solution, but can result in uncorrect position/dimension calculations "hide_mode: visibility": should be the most compatible version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
hide_mode, the dropdown hide method can be changed to prevent different problems.hide_mode: null(default): uses the old"left": -9000to be backward compatible, but is problematic with very wide pages and with RTL.hide_mode: "display": uses display hide/block, should be the most performant solution, but may result in uncorrect position/dimension calculationshide_mode: "visibility": should be the most compatible versionTested on a page with ~12000px x ~3000px and ~300 chosen dropdowns, with current Chrome & Firefox.