Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the julia-version input to channel #61

Merged
merged 4 commits into from
May 30, 2024
Merged

Rename the julia-version input to channel #61

merged 4 commits into from
May 30, 2024

Conversation

DilumAluthge
Copy link
Member

Fixes #59

This is a breaking change.

@DilumAluthge
Copy link
Member Author

@davidanthoff I went with channel here, but if you prefer, I can rename it to juliaup-channel.

@davidanthoff
Copy link

I think channel makes the most sense. The only time we add julia to that name is for the env var JULIAUP_CHANNEL, but that is only because it is essentially a global namespace. Everywhere else where it is clear that things are in the Juliaup context, we just use channel, so I think that makes most sense here as well. So: thumbs up :)

@DilumAluthge
Copy link
Member Author

I'll hold off on merging this until we decide if there any other breaking changes we want to make. Then we can make a single breaking release that includes all of the breaking changes in a single release.

@DilumAluthge DilumAluthge marked this pull request as ready for review May 20, 2024 14:09
@DilumAluthge
Copy link
Member Author

@davidanthoff Shall we merge this now, and tag a breaking v2?

Are there any other breaking changes that we want to include in v2?

@davidanthoff
Copy link

Looks good to me, I'd say lets merge and do a v2! I can't think of any other breaking things right now.

@DilumAluthge DilumAluthge added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit 1bd0233 May 30, 2024
13 checks passed
@DilumAluthge DilumAluthge deleted the dpa/channel branch May 30, 2024 20:41
@DilumAluthge
Copy link
Member Author

I'll create the v2.0.0 and v2 tags.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented May 30, 2024

My TODO list:

@DilumAluthge
Copy link
Member Author

I have finished the tasks in my above TODO list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we use juliaup-channel (or just channel) instead of julia-version?
2 participants