Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Windows system tar (not the Git Bash tar) #206

Merged
merged 10 commits into from
Jun 19, 2024
Merged

Use Windows system tar (not the Git Bash tar) #206

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1cc831a
use windows tar, not git bash one
IanButterworth Jan 15, 2024
9d2d860
correct manual patch
IanButterworth Jan 15, 2024
123ab28
rebuild
IanButterworth Jan 15, 2024
438ebed
Merge branch 'master' into ib/win_tar
IanButterworth Jan 15, 2024
76b7440
Update src/installer.ts
IanButterworth Jan 15, 2024
b8d3686
Update installer.js
IanButterworth Jan 15, 2024
4b017b9
Merge branch 'master' into ib/win_tar
ViralBShah May 3, 2024
1063fd9
Merge branch 'master' into ib/win_tar
DilumAluthge Jun 19, 2024
78915a8
Include the direct URL of the issue (not just the issue number)
DilumAluthge Jun 19, 2024
90a5ee7
npm run build
DilumAluthge Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/installer.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ export async function installJulia(dest: string, versionInfo, version: string, a
}
} else {
// This is the more common path. Using .tar.gz is much faster
await exec.exec('powershell', ['-Command', `tar xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`])
// don't use the bit bash provided tar. Issue #205
IanButterworth marked this conversation as resolved.
Show resolved Hide resolved
await exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`])
}
return dest
case 'darwin':
Expand Down