Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type in completion details #1052

Merged
merged 7 commits into from Apr 29, 2022
Merged

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Apr 8, 2022

and hover.

image
image

ToDo:

  • Tests
  • improve completion_kind heuristics

@fredrikekre
Copy link
Member

Tested your example in neovim:

Would be nice to get both fields to show the same kind?
Screenshot from 2022-04-09 00-08-47

The details look very strange:
Screenshot from 2022-04-09 00-09-12
Screenshot from 2022-04-09 00-09-24

Hover looks like in your example:
Screenshot from 2022-04-09 00-09-43

But completion details again look strange:
Screenshot from 2022-04-09 00-10-27

@pfitzseb
Copy link
Member Author

You wanna give this another go, @fredrikekre ? I didn't fix anything related to CompletionKinds yet (well, except for removing the Enum fallback; anything else requires a deep dive into SymbolServer and I don't have the time for that atm), but completions should already be more helpful.

@fredrikekre
Copy link
Member

Looks good, the strange double type things are gone (x::Int::Int64 etc).

@pfitzseb pfitzseb marked this pull request as ready for review April 29, 2022 09:40
@pfitzseb pfitzseb merged commit 3c5fc4d into master Apr 29, 2022
@davidanthoff davidanthoff deleted the sp/better-completion-details branch May 2, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants