fix: use !isuppercase instead of islowercase in completion logic #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfitzseb
changed the title
we're not really interested in whether all chars are lowercase (which is only true for letters); instead we want to determine whether the user manually upper-cased any chars and treat that as a signal that they care about the casing.
pfitzseb
force-pushed
the
sp/completion-lowercase
branch
from
75188f8
to
6c84707
Compare
davidanthoff
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're not really interested in whether all chars are lowercase (which is only true for letters); instead we want to determine whether the user manually upper-cased any chars and treat that as a signal that they care about the casing.
Fixes #1175.