Fall back to displaying SymbolServer indexing progress on stderr #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of fully-capable clients (such as VS code) get a sense of the progress being made by `SymbolServer` while indexing packages. However, clients which don't have the capability to display progress notifications get no information whatsoever. This proposal falls back to simply displaying indexing progress on stderr for such clients. This helps at least when using the `LanguageServer` within Emacs via `eglot`, which allows to easily display the server output for debugging purposes. I'm not sure whether there are other clients for which such additional output would be unwelcome...
non-Jedi
approved these changes
May 20, 2020
davidanthoff
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of fully-capable clients (such as VS code) get a sense of the progress being made by
SymbolServerwhile indexing packages. However, clients which don't have the capability to display progress notifications get no information whatsoever. This proposal falls back to simply displaying indexing progress on stderr for such clients.This helps at least when using the
LanguageServerwithin Emacs viaeglot, which allows to easily display the server output for debugging purposes. I'm not sure whether there are other clients for which such additional output would be unwelcome...