Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable non-at-eval macrocall linting #290

Merged
merged 4 commits into from Jul 26, 2021
Merged

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Jun 7, 2021

for bindings and refs. This shouldn't be too expensive, even though a bit hacky.

Fixes julia-vscode/julia-vscode#2187.

For every PR, please check the following:

@pfitzseb pfitzseb requested a review from a team June 7, 2021 13:52
ZacLN
ZacLN previously approved these changes Jul 21, 2021
Copy link
Contributor

@ZacLN ZacLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle. If the call added in collect_hints proves costly I think it can be wrapped up (messily) into the call to is_in_fexpr earlier in the line.

Tests need looking at

@davidanthoff davidanthoff merged commit 7b5e33b into master Jul 26, 2021
@davidanthoff davidanthoff deleted the sp/no-macrocall-linting branch July 26, 2021 17:12
@ZacLN ZacLN mentioned this pull request Aug 8, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyword arguments to macros confused with local variables
3 participants