-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+C not working with ProgressLogging #3556
Comments
If you hit Ctrl-C three times within a second, we'll send out an interrupt signal, which doesn't require your inner loop to yield, but may be unsafe (i.e. it may interrupt not your code, but something internal to the extension). It's probably worth adding a setting for always sending the signal on supported platforms though. |
Thanks for the tip! Unfortunately, for me this doesn't interrupt the process. |
Peek.2024-03-04.16-06.webmThat works semi-reliably for me. What OS are you on? |
Windows 10, now I also tried running via Ctrl+Enter as you do in the video, but still it doesn't interrupt. Even when holding in Ctrl+C for 10s of seconds (or pressing 20x times) (after increasing the runtime). I've tried it on two computers running basically same setup though (Win 10, Julia 1.10.1/1.10.2, extension v1.73.2, vscode 1.87. vs code about
|
Ah, yeah, that explains it. We can't really do better than that on Windows, unfortunately, except for majorly reworking how code is evaluated in VS Code. |
When running (via
include("my_file.jl")
) the MWE below, interrupting with Ctrl+C doesn't work unless taking the sleeping branch: It keeps running until the iterations complete.While I guess this is related to long-standing issues in Julia (e.g. JuliaLang/julia#35524), it works when using
TerminalLoggers.jl
(and running outside VSCode).So I'm just putting it here in case someone would have an idea how to fix the behavior.
versioninfo
Running VSCode plugin
v1.73.2
The text was updated successfully, but these errors were encountered: