Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getvariables check #2833

Merged
merged 1 commit into from Apr 6, 2022
Merged

Fix getvariables check #2833

merged 1 commit into from Apr 6, 2022

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Apr 5, 2022

Fixes #2832.

davidanthoff
davidanthoff approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that already fixed by #2831?

@pfitzseb
Copy link
Member Author

pfitzseb commented Apr 6, 2022

Nope. This fix isn't for missing but for PyObjects and is generally more robust.

@pfitzseb pfitzseb merged commit d6a0a71 into master Apr 6, 2022
@davidanthoff davidanthoff deleted the sp/fix-getvariables-checks branch April 6, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyReverseDims crash in remote vscode
2 participants
@pfitzseb @davidanthoff