Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/methodswith dot completion #3240

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Mar 9, 2023

Fixes #2679 . Works together with julia-vscode/LanguageServer.jl#1210.

A quick demo of concept. Need runtime completion enabled.

Still work needed:

  • additional edit to delete previous identifier.
  • performance issue when using lots of modules
  • move cursor to middle of ",)"
  • better way of extracting identifier.
  • whether allow custom setting of REPL completion promise timeout.

For every PR, please check the following:

  • End-user documentation check. If this PR requires end-user documentation, please add that at https://github.com/julia-vscode/docs.
  • Changelog mention. If this PR should be mentioned in the CHANGELOG, please edit the CHANGELOG.md file in this PR.

@xgdgsc xgdgsc changed the title WIP Feat/methodswith dot completion Feat/methodswith dot completion Jul 16, 2023
@xgdgsc
Copy link
Contributor Author

xgdgsc commented Jul 18, 2023

I' ve used this for months just fine. @pfitzseb What' s your opinion on this? Any plan on merging or what needed changing for merging? Judging from https://discourse.julialang.org/t/allowing-the-object-method-args-syntax-as-an-alias-for-method-object-args/62051/218?u=xgdgsc . There could be a lot of people need this for coming from OOP or working together with OOP languages.

@3f6a
Copy link

3f6a commented Aug 22, 2023

Please consider adding a setting to disable this feature if desired. It's possible some users might not want to have a list of suggestions including methods that can apply to a given value.

@ParadaCarleton
Copy link

@pfitzseb short reminder on this; do you think it could be merged before the next VSCode update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: show methods applicable to object (methodswith)
3 participants