-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cbind/cbind! and copies #21
Comments
I completely concur. Let's go with your proposed design. We should specify, however, that any meta-data (if we had any) associated with DataFrames, would get copied from df1. |
I just pushed a change to fix this plus added hcat and vcat. I also deleted the version of cbind that allowed name/column pairs. I think we should add that back in once Julia has keyword function arguments. As it is now, the easiest way to get that is assignment. It looks like I should have referenced this issue in my push. Anyway, I'll wait to close this until someone else looks at it. |
Looks good! (Yeah, referring to issue numbers is always a good idea...) |
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
These either should have been changed to JuliaData, or the mentions should have been removed completely. DataFramesMeta in particular does not currently support DataTables, though we might update it at some point. This should fix uploading the online manual.
Julia-dev discussion
cbind(df1, df2) currently makes copies of both df1 and df2 (expensive)
cbind!(df1, df2) currently makes no copies and modifies df1
We need something that doesn't copy columns but doesn't modify df1 or df2. I'd rather have:
cbind(df1, df2) be equivalent to DataFrame([df1.columns, df2.columns], newcolnames)
That doesn't change df1 or df2, but they share columns. If we have that, I don't see too much need for cbind!.
Creating a DataFrame from existing columns isn't expensive.
The text was updated successfully, but these errors were encountered: