Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbind/cbind! and copies #21

Closed
tshort opened this issue Jul 15, 2012 · 3 comments
Closed

cbind/cbind! and copies #21

tshort opened this issue Jul 15, 2012 · 3 comments

Comments

@tshort
Copy link
Contributor

tshort commented Jul 15, 2012

Julia-dev discussion

cbind(df1, df2) currently makes copies of both df1 and df2 (expensive)
cbind!(df1, df2) currently makes no copies and modifies df1

We need something that doesn't copy columns but doesn't modify df1 or df2. I'd rather have:

cbind(df1, df2) be equivalent to DataFrame([df1.columns, df2.columns], newcolnames)

That doesn't change df1 or df2, but they share columns. If we have that, I don't see too much need for cbind!.

Creating a DataFrame from existing columns isn't expensive.

@HarlanH
Copy link
Contributor

HarlanH commented Jul 15, 2012

I completely concur. Let's go with your proposed design. We should specify, however, that any meta-data (if we had any) associated with DataFrames, would get copied from df1.

@tshort
Copy link
Contributor Author

tshort commented Jul 15, 2012

I just pushed a change to fix this plus added hcat and vcat. I also deleted the version of cbind that allowed name/column pairs. I think we should add that back in once Julia has keyword function arguments. As it is now, the easiest way to get that is assignment.

It looks like I should have referenced this issue in my push. Anyway, I'll wait to close this until someone else looks at it.

@HarlanH
Copy link
Contributor

HarlanH commented Jul 15, 2012

Looks good! (Yeah, referring to issue numbers is always a good idea...)

@HarlanH HarlanH closed this as completed Jul 15, 2012
nalimilan added a commit that referenced this issue Jul 8, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
nalimilan added a commit that referenced this issue Jul 8, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
nalimilan added a commit that referenced this issue Jul 8, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
nalimilan added a commit that referenced this issue Jul 8, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
nalimilan added a commit that referenced this issue Jul 8, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
rofinn pushed a commit that referenced this issue Aug 17, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
nalimilan added a commit that referenced this issue Aug 25, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
quinnj pushed a commit that referenced this issue Sep 2, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
quinnj pushed a commit that referenced this issue Sep 2, 2017
These either should have been changed to JuliaData, or the mentions should
have been removed completely. DataFramesMeta in particular does not currently
support DataTables, though we might update it at some point.

This should fix uploading the online manual.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants