Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename grid to groups #116

Closed
maleadt opened this issue Mar 3, 2023 · 2 comments
Closed

Rename grid to groups #116

maleadt opened this issue Mar 3, 2023 · 2 comments
Labels
speculative Note sure if we want this.

Comments

@maleadt
Copy link
Member

maleadt commented Mar 3, 2023

It's currently confusing whether the grid kwarg to @metal should indicate the total grid, or just the number of threadgroups that make up the grid. The underlying API call is https://developer.apple.com/documentation/metal/mtlcomputecommandencoder/1443138-dispatchthreadgroups?language=objc, which uses threadgroupsPerGrid and threadsPerThreadgroup, so I guess we could rename to threads and groups for brevity.
@maleadt maleadt added the speculative Note sure if we want this. label Mar 3, 2023
@christiangnrd
Copy link
Contributor

Should #119 close this?

@maleadt
Copy link
Member Author

maleadt commented Mar 16, 2023

Yep, thanks.

@maleadt maleadt closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
speculative Note sure if we want this.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @christiangnrd