Rename grid to groups #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Mar 6, 2023
There was a problem hiding this comment.
LGTM. We should probably do this change as a two step process, as it is right now: break @metal grid first so that existing users upgrade, and afterwards introduce @metal grid again with the new semantics.
I prefer simply groups over threadgroups, but could be convinced otherwise if anybody feels strongly.
I'd also keep the README examples simple; it should demonstrate @metal groups, but let's keep the more complex examples for the documentation.
Co-authored-by: Christian Guinard <chguinard99@gmail.com>
maleadt
force-pushed
the
np/threadgroups
branch
from
8da8fa2
to
5812cf6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, Metal.jl was using the term
gridin a way that is inconsistent with Apple's terminology.Things to consider adding to this PR
groupskeyword?