Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test on 3.10.2 #61

Closed
nico202 opened this issue Mar 24, 2021 · 4 comments
Closed

Failing test on 3.10.2 #61

nico202 opened this issue Mar 24, 2021 · 4 comments

Comments

@nico202
Copy link

nico202 commented Mar 24, 2021 •
edited
Loading

On my machine, using latest tag, there's a failing test:

misc tests: Test Failed at /gnu/store/vjn5iayr1iz6mb40qck86xxr9mpbqiz8-julia-colorschemes-3.10.2/share/julia/packages/ColorSchemes/test/runtests.jl:105
Expression: y2 == y[1]
Evaluated: RGB{Float64}(0.17442110750186596,0.10479916072572365,0.07055654401306825) == RGB{Float64}(0.17442110750186593,0.10479916072572365,0.07055654401306825)
@cormullion
Copy link
Member

😂 Thanks - shouldn't be using == there I think...

@nico202
Copy link
Author

nico202 commented Mar 24, 2021

Let's ignore this 0.00000000000000003 difference :')
thanks! :)

@cormullion
Copy link
Member

trying a fix with #61 ...

@nico202
Copy link
Author

nico202 commented Mar 29, 2021

Thanks! Last commit does work. Would you also mind tagging the 3.11 release? I saw the version changed in the project.toml, but no git tag

Thanks!

@nico202 nico202 closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cormullion @nico202