Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libz compliance with FileIO for GZ format #120

Closed
hpoit opened this issue May 16, 2017 · 2 comments
Closed

Libz compliance with FileIO for GZ format #120

hpoit opened this issue May 16, 2017 · 2 comments

Comments

@hpoit
Copy link
Contributor

hpoit commented May 16, 2017

Hi @SimonDanisch and @timholy,

In general terms, what does it mean to make Libz compliant with FileIO? That's my next goal.
Libz can read from a GZ and write to another GZ. FileIO just detects the GZ format and dispatches it to Libz, which I believe I've already done with add_format(format"GZIP", [0x1f, 0x8b], ".gz", [:Libz]).

Is there any more compliance to be done between the two?

Cheers, HP

@hpoit hpoit changed the title Libz compliance Libz compliance with FileIO for GZ format May 16, 2017
@SimonDanisch
Copy link
Member

Yes, that looks correct!
Please refer to the documentation for implementing the loading scheme:
https://github.com/JuliaIO/FileIO.jl#implementing-loaderssavers
Or have a look at a library that already implements this, e.g:

https://github.com/JuliaIO/NRRD.jl/blob/master/src/NRRD.jl#L199
https://github.com/JuliaIO/MeshIO.jl/blob/master/src/MeshIO.jl#L20

Best,
Simon

@timholy
Copy link
Member

timholy commented Mar 3, 2021

I don't think there's anything more to do here but wait for a PR.

@timholy timholy closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants