Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to put in Require #42

Closed
SimonDanisch opened this issue Oct 1, 2015 · 4 comments
Closed

What to put in Require #42

SimonDanisch opened this issue Oct 1, 2015 · 4 comments

Comments

@SimonDanisch
Copy link
Member

As discussed in JuliaImages/Images.jl@2762928#commitcomment-13530108 and https://github.com/timholy/Images.jl/pull/374/files#r40807839

Solutions:

  • put Important packages in the Require
  • list of recommended packages
  • when it's detected that a package could load a file, but it's not installed, prompt the user to install it (maybe even offering to install it automatically)

I'm in favor of the last option, since it deals with the problem of only installing the minimal set of needed packages while still keeping usability up high.

I can prepare a PR when you all agree!

Best,
Simon

@SimonDanisch
Copy link
Member Author

The more I try to fix errors in the ImageMagick and QuartzImageIO builds, the more I'm convinced that option 3 is the way to go. Putting anything in any REQUIRE seems to lead to hassle, if someone prefers another package than in the REQUIRE.

@timholy
Copy link
Member

timholy commented Oct 1, 2015

Prompting seems reasonable to me; I was beginning to come to the same conclusion.

@rsrock
Copy link
Contributor

rsrock commented Oct 1, 2015

I agree, this should be under the user's control

@timholy
Copy link
Member

timholy commented Oct 1, 2016

Fixed

@timholy timholy closed this as completed Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants