-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimum(p)
returns the minimal coefficient of p
but minimum(p, itr)
returns when p
is applied onto itr
#459
Comments
Although, |
Yes, with the newer PR we would have:
|
I have thought about the API, I will list the one that looks idiomatic to me: minimum(p, list_of_points)
maximum(p, list_of_points) returns the smallest/largest result of calling polynomial The only one thing I am not sure is that minimum(p)
maximum(p) returns the minimum coefficients and maximum coefficients of findmin(p, domain) -> (p(x), x)
findmax(p, domain) -> (p(x), x) returns a pair of a value in the codomain (outputs of That is, argmin(p, domain)
argmax(p, domain) Similar to extrema(p, list_of_points) returns the results of |
The current PR has the following docstring: """ Return the critical points of
Can be used in conjuction with Example
""" If you want to suggest edits that would be great. It might be worth commenting how maximum(p) and maximum(p, critical_points(p)) will return different things, the latter in agreement with findmax(p, critical_points(p)) and the former in agreement with maximum(coeffs(p)) |
I feel like someone calling |
Agree. That is what I was thinking. |
A math person might, but a julia person would expect, I believe, that |
This is a derivative of what we talked about in #454. However, when I just apply
minimum
to a polynomial, it returns some weird result:Clearly, the minimum value of
p
returns the minimal coefficient inp
, which is1
; butminimum(p, -10:10)
returns the minimum ofp.(-10:10)
, which is the lowest point on the graph:-7
.These definitions conflict with each other.
The text was updated successfully, but these errors were encountered: