-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Version(unsure what version) Incompatible with Fastload #129
Comments
Okay ignore the old comment, I tested on 1.20.1 and things seemed fine there, I can reproduce this on 1.19.2. |
ah my bad, forgot to mention mc version, ran this on 1.19.4 for more details. |
Well questionable decisions aside, the reason this breaks is that Dynamic FPS will skip rendering the world while the loading overlay or an opaque screen is currently overlaid over the world (e.g. when you have switched resource packs, or are in any screen with the dirt background) to help with performance on lower end systems. Usually this optimization also breaks the vanilla loading screen, but we disable this optimization specifically for it: Dynamic-FPS/src/main/resources/fabric.mod.json Lines 62 to 64 in d9b700a
I can create a PR for Fastload to also fix this with their loading screen, but since their project is inactive at this time I doubt it would get accepted in a timely manner. If you (or anyone else) would like to use these mods together you can add this to your https://files.lostluma.net/dynamic-fps-fastload-fix.jar (don't delete Dynamic FPS, just add this mod) |
o7 thanks for the help! |
Reported the issue on the other repo and will also submit a PR with a fix in a few minutes. I'll close this since it's inactionable. |
So I updated DynamicFPS today, it worked when I played MC with v2.2.0 I also downgraded to v3.0.0 and it seems it's still incompatible, downgrading back to v2.2.0 and it didn't lead to loading screen lock,
Steps to Reproduce:
It seems Fastload is no longer maintained but the latest version it has is from May, and since DynamicFPS updated last, I figured to add an issue here.
The text was updated successfully, but these errors were encountered: