Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't dynamic FPS work with FastLoad? #169

Closed
StarsShine11904 opened this issue Feb 22, 2024 · 3 comments 路 Fixed by #171
Closed

Why doesn't dynamic FPS work with FastLoad? #169

StarsShine11904 opened this issue Feb 22, 2024 · 3 comments 路 Fixed by #171
Labels
enhancement New feature or request support End user support with the software

Comments

@StarsShine11904
Copy link

Why can't it be executed with FastLoad after updating to 3.4.1?
Can I know the reason?馃

@LostLuma
Copy link
Collaborator

Hello, quite a while it was reported to us that using Dynamic FPS and FastLoad together will lead to you being softlocked in the world loading screen (see #129). As mentioned in the aforementioned issue comments we luckily also have functionality to fix this behavior if another mod requests it, which I have reported on their issue tracker, and have also submitted the fix for.

Since the user experience of installing a bunch of mods and then simply being stuck on the world loading screen is arguable pretty poor I thought it would be acceptable to block all current versions of FastLoad from being loaded in tandem with Dynamic FPS, assuming that if they (at some point, it's been 150 days since it seems the author has quit modding ..?) make a new release the situation would be resolved.

The reason that I would've like FastLoad to adopt usage of this way of fixing the issue is that they can update their mod as they wish in the future and change it as needed, without us needing to keep track of their releases and shipping a new version of Dynamic FPS in case something significant changed.


With that being said, since the author seems to not intend to work on the mod again (and no one has stepped up to maintain it) it might be reasonable for us to fix this ourselves if FastLoad 3.4.0 or older is present (assuming if there's a future release it'll be fixed on their end).

For right now if you would like to run these mods together you can use a dependency override, they exist for both Fabric and Quilt.

@LostLuma LostLuma added enhancement New feature or request support End user support with the software labels Feb 22, 2024
@LostLuma
Copy link
Collaborator

I've decided to actually spend some time doing this so this issue will be resolved in our next release.

@StarsShine11904
Copy link
Author

I understand, I will wait for the next version update

But I have fixed FastLoad by modifying the module config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request support End user support with the software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants