Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips and named slider options to config screen #131

Merged

Conversation

LostLuma
Copy link
Collaborator

@LostLuma LostLuma commented Oct 4, 2023

Fixes up some config screen stuff I missed previously because I did not realize it's possible :)

  • Volume multiplier and graphics options values use proper labels / are now translatable
  • Tooltips as warning for minimal graphics state, and to explain what the toast and gc options do
  • The frame rate target slider now has an "Unlimited" option on the right instead of the magic -1 value

Screenshot of the config screen with these changes applied

@EuropaYou
Copy link
Contributor

Use a translation service like Crowdin so that translators don't need to open a PR whenever there are changes, like this PR.

@EuropaYou
Copy link
Contributor

Also you can use Minecraft translations by converting:

config.dynamic_fps.graphics_state_default to options.gamma.default
config.dynamic_fps.graphics_state_reduced to options.particles.decreased (Reduced to Decreased)
config.dynamic_fps.graphics_state_minimal to options.particles.minimal

@LostLuma
Copy link
Collaborator Author

LostLuma commented Oct 4, 2023

Use a translation service like Crowdin so that translators don't need to open a PR whenever there are changes, like this PR.

I don't think it's really worth it for a mod that will not receive many more features. I plan to resolve the last two outstanding feature requests (per category volume control, AFK frame rate reduction) and then only really port the existing functionality to new Minecraft versions. Note that adding those two also only adds one string for the AFK amount / timer - configuring what the mod does when it detects you as away will work the same way the current categories do.

Also you can use Minecraft translations by converting:

As for the default / reduced / minimal strings that's a good idea, I'll do that before merging :)

@LostLuma LostLuma merged commit d5cea63 into juliand665:main Oct 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants