Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deep merge #3

Closed
dankelleher opened this issue Oct 24, 2018 · 2 comments
Closed

Support deep merge #3

dankelleher opened this issue Oct 24, 2018 · 2 comments

Comments

@dankelleher
Copy link
Contributor

dankelleher commented Oct 24, 2018

I would like to be able to do something like this:

package.json

{
  "dependencies": {
    "dep1": "1.0.0",
    "dep2": "1.0.0"
  }
}

environments.json

{
  "dev": {
    "dependencies": {
      "dep1": "1.2.0"
    }
  },
  "staging": {
    "dependencies": {
      "dep1": "1.1.0"
    }
  }
}

At the moment this is not possible, because the merge is shallow, so running penv dev with the above configuration would remove dep2.

dankelleher added a commit to civicteam/penv that referenced this issue Oct 24, 2018
@dankelleher
Copy link
Contributor Author

PR here: #4

dankelleher added a commit to civicteam/penv that referenced this issue Oct 24, 2018
julianduque pushed a commit that referenced this issue Nov 12, 2018
@julianduque
Copy link
Owner

@dankelleher landed in v0.2.0! Thanks!!! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants