Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmap issue for Julia version > 0.6.1 #20

Closed
dawnsong opened this issue Nov 7, 2018 · 2 comments
Closed

Mmap issue for Julia version > 0.6.1 #20

dawnsong opened this issue Nov 7, 2018 · 2 comments

Comments

@dawnsong
Copy link

dawnsong commented Nov 7, 2018

Thanks for the NIfTI module.
For Julia v0.6.4, it is not compatible because of Mmap.
I think the code should be changed from

if VERSION > v"0.6.1"
using Mmap
end

to

if VERSION > v"0.6.1"
using Base.Mmap
end

@Tokazama
Copy link
Member

Tokazama commented Nov 8, 2018

The current release doesn't have that line in it, nor does it support anything under v0.7. I'm sure it would be possible to add support for older versions but I think that enough of the package ecosystem is starting to converge on v1+ that it may be better to update at this point.

That being said, if you can't update for some reason you could always Pkg.develop an older release and implement the change yourself. See this for more details on this approach.

@dawnsong
Copy link
Author

dawnsong commented Nov 8, 2018

Thanks for the explanation. I am sticking to v0.6 since many packages are dependent on it.
I also look forward to all new updates, specially for the v1.0 releases.

@dawnsong dawnsong closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants