"remove" method on instance #635
Merged
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkAce65
commented
Dec 11, 2019
| @@ -1141,20 +1146,24 @@ function removeTargetsFromAnimations(targetsArray, animations) { | |||
| } | |||
| } | |||
|
|
|||
| function removeTargets(targets) { | |||
| function removeTargetsFromInstance(targetsArray, instance) { | |||
| const animations = instance.animations; | |||
There was a problem hiding this comment.
This is all the same logic as before, just moved to a separate function for reuse
|
Nice PR, and thanks for updating the doc accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacking off of #501, this adds a
removemethod to each anime instance so that individual animations and timelines can be controlled more precisely. The new remove method accepts any valid target in the same way as the globalanime.remove(targets)but only affects the instance (and children of the instance) that it is called on.The docs have also been updated to show both methods.
Semi-related issues: #318 #286.