Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StatsModels compatibility and remove REQUIRE #53

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Add StatsModels compatibility and remove REQUIRE #53

merged 2 commits into from
Jun 26, 2019

Conversation

mmolignano
Copy link
Contributor

Removed deprecated REQUIRE file.

Added a compatibility for StatsModels to version 0.5.0 until Bootstrap can be updated against newest release of StatsModels (0.6.0).

This address comments in #52

@juliangehring juliangehring self-requested a review June 26, 2019 20:43
juliangehring
juliangehring reviewed Jun 26, 2019
View reviewed changes
Copy link
Owner

@juliangehring juliangehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have left a comment regarding the version compatibility with pre 0.5 versions.

Project.toml Show resolved Hide resolved
@juliangehring juliangehring merged commit 23d63c0 into juliangehring:develop Jun 26, 2019
@juliangehring
Copy link
Owner

Thanks, much appreciated!

@juliangehring juliangehring mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangehring juliangehring juliangehring left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmolignano @juliangehring