Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow DataFrames.jl 1.0 and bump package version #83

Merged
merged 3 commits into from
Apr 28, 2021
Merged

allow DataFrames.jl 1.0 and bump package version #83

merged 3 commits into from
Apr 28, 2021

Conversation

bkamins
Copy link
Contributor

@bkamins bkamins commented Apr 24, 2021

No description provided.

@haberdashPI
Copy link

One thought here: it seems like it should be relatively straightforward to remove DataFrames as a dependency and use Tables and PrettyTables in its stead, reducing the overall heft of Bootstrap's dependencies. I'd be happy to submit a PR for that.

@bkamins
Copy link
Contributor Author

bkamins commented Apr 26, 2021

I would prefer it this way.

@juliangehring
Copy link
Owner

juliangehring commented Apr 28, 2021 •
edited
Loading

@bkamins Thank you!
Could you change the PR to merge into develop instead of master? Never mind, I have changed it.

@juliangehring juliangehring mentioned this pull request Apr 28, 2021
Closed
@juliangehring juliangehring changed the base branch from master to develop April 28, 2021 07:37
@juliangehring juliangehring self-requested a review April 28, 2021 07:50
juliangehring
juliangehring requested changes Apr 28, 2021
View reviewed changes
Copy link
Owner

@juliangehring juliangehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing with DataFrames v1.0, likely due to non-backwards compatible conversion methods between types.

@bkamins
Copy link
Contributor Author

bkamins commented Apr 28, 2021

fixed

juliangehring
juliangehring approved these changes Apr 28, 2021
View reviewed changes
Copy link
Owner

@juliangehring juliangehring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliangehring juliangehring merged commit 5d1c4e6 into juliangehring:develop Apr 28, 2021
@bkamins bkamins deleted the patch-1 branch April 28, 2021 19:58
@juliangehring juliangehring mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliangehring juliangehring juliangehring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkamins @haberdashPI @juliangehring