Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Jekyll doesn't like the Readme.md #22

Closed
claytron5000 opened this issue Mar 29, 2017 · 15 comments
Closed

Building Jekyll doesn't like the Readme.md #22

claytron5000 opened this issue Mar 29, 2017 · 15 comments

Comments

@claytron5000
Copy link

claytron5000 commented Mar 29, 2017

When attempting to build a Jekyll site on Github, I'm getting this error:
I'm getting this error Your site is having problems building: The variable {{a} on line 50 in node_modules/balanced-match/README.md was not properly closed with }}. For more information, see https://help.github.com/articles/page-build-failed-tag-not-properly-terminated/.

@claytron5000
Copy link
Author

:palm: :face: I was not ignoring the node_modules directory. PR could still be merged in, but not nearly urgent.

@keyolk
Copy link

keyolk commented Apr 13, 2017

I got same problem : (

@juliangruber
Copy link
Owner

@keyolk hey, why do you need to build this README using jekyll?

@claytron5000
Copy link
Author

@keyolk Add /node_modules to your .gitignore. My understanding is that the syntax check is occurring before the build process, so the balanced-match directory (and thus the README) won't be run through whatever syntax checker is finding the error. That said, I think my PR would fix this problem if users forget to gitignore the node_modules directory.

@TommyJackson85
Copy link

I fixed it adding node_modules/* as-well (I referenced it above).
Just for further notice, if node_modules has already been uploaded to the repository, adding node_modules/* to .gitignore wont be enough. You will need to untrack node_modules from the repository using the following command: git rm --cached node_modules -r :)

@cortehz
Copy link

cortehz commented May 25, 2018

@TommyJackson85 I added gitignore, also untracked node_modules from my repo but I still get the same page build error. Why so?

@TommyJackson85
Copy link

did you add the following to your gitIgnore file?

node_modules/*
.idea/

Try running
'git rm --cached node_modules -r' first
and then add the gitignore file, then update your repository

Maybe use this help document.
https://help.github.com/articles/ignoring-files/

This method is what I used add the gitignore file and untrack the previously committed node_modules. When i ran 'git rm --cached FILENAME' command (file name being node_modules) it prompted me to include '-r'.

@cortehz
Copy link

cortehz commented May 26, 2018

Thanks, @TommyJackson85 I finally got it to work.

@juliangruber
Copy link
Owner

I'm going to close this now, thank's everyone for figuring it out!

@bhagwatn2021
Copy link

@TommyJackson85 I tried your advice. It is updating the build to Github but somehow it is not showing changes on my GitHub page.

@varunsingh87
Copy link

varunsingh87 commented Oct 16, 2018

I am still having this problem - the exact same problem said in the beginning.
My repository where the problem is can be found here: https://github.com/KnowledgeableKangaroo/supreme-guacamole

I have the node_modules folder in the Codecademy subdirectory. So, I ignored Codecademy/node_modules/* in my .gitignore. I then listed all ignored files in git bash locally and it showed exactly what I expected. I also escaped the apostrophes shown at the top in the first linked issue. However, I still get these emails and in settings it still shows

Your site is having problems building: The variable {{a} on line 50 in Codecademy/node_modules/balanced-match/README.md was not properly closed with }}. For more information, see https://help.github.com/articles/page-build-failed-tag-not-properly-terminated/

When I try git rm --cached node_modules -r, I can't commit the changes to push to the origin because I am getting a 'exit code 1 received` error.

@claytron5000
Copy link
Author

@KnowledgeableKangaroo Are you building master or your tagged v1.1.4 branch? I ask because I noticed you don't have the node_modules directory in master, but it is in the v1.1.4 branch.

@varunsingh87
Copy link

@claytron5000 I 'solved' the problem by deleting the node_modules directory in the Codecademy subdirectory completely which go rid of the problem and I wasn't using that at the moment. however, before, it was in the master branch. I have had this package for a while, but only now have I decided to make the publishing source of my GitHub Pages the master branch and this issue came up with it.

@ccsalison
Copy link

I had the same issue and I deleted my node_modules directory after figuring out that I don't need it anyway.

@htshon
Copy link

htshon commented Jul 22, 2020

Hello dude , Your site is having problems building: The variable {{a} on line 50 in node_modules/balanced-match/README.md was not properly closed with }}. For more information, see https://help.github.com/articles/page-build-failed-tag-not-properly-terminated/

This is showing to me also how I can fix it .
I have completed the project but this is final stage where I am stucked .
I have to submit it to my college

Reply as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants