Escape RegExp curly brace #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape '}' in regular expression for better compatibility with other JavaScript interpreters. It seems like `Ducktype` is not able to properly parse `brace-expansion` due to the unescaped curly brace. See: svaarala/duktape#74
|
I'm trying to use |
juliangruber
added a commit
that referenced
this pull request
Feb 11, 2016
Escape RegExp curly brace
|
published a patch as 1.1.3, hopefully it floats up |
|
Excellent. Hope that's all there is to it. |
|
Seems to work here. Great stuff, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape '}' in regular expression for better compatibility with other
JavaScript interpreters. It seems like
Ducktypeis not able toproperly parse
brace-expansiondue to the unescaped curly brace.See: svaarala/duktape#74