Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron update for Apple M1 support #158

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

fanatid
Copy link
Contributor

@fanatid fanatid commented Apr 5, 2021

This is temporary PR with a demonstration that things work. Once dependencies will be released PR will be updated.

Tracked PR:

@fanatid
Copy link
Contributor Author

fanatid commented Apr 6, 2021

Dependencies updated. Tested locally on v10.0.0 (lowest version from .travis.yml) on linux-x64.

@juliangruber
Copy link
Owner

Nice work, is this good to go then?

@fanatid
Copy link
Contributor Author

fanatid commented Apr 6, 2021

Well, local tests are passed now :)
I still trying to compile wasm in my another PR (bitcoinjs/tiny-secp256k1#53) and did not run tests there yet. If you want I can leave a comment here once will able to run tests with browser-run.

@juliangruber
Copy link
Owner

Alright, I think this should be fine, but ping me nevertheless please :)

@juliangruber juliangruber merged commit 45d09e7 into juliangruber:master Apr 6, 2021
@fanatid fanatid deleted the deps-fix branch April 6, 2021 08:02
@juliangruber
Copy link
Owner

https://github.com/juliangruber/browser-run/releases/tag/v10.0.0

@fanatid
Copy link
Contributor Author

fanatid commented Apr 6, 2021

I was able to run my tests with browser-run on M1. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants