move traversable check

juliangut · Jun 4, 2017 · 6306434 · 6306434
1 parent 298f707
commit 6306434
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/RepositoryTrait.php b/src/RepositoryTrait.php
@@ -374,17 +374,21 @@ protected function runManagerAction(string $action, $objects, bool $flush)
             $manager->$action($object);
         }
 
-        $this->flushObjects($objects instanceof \Traversable ? iterator_to_array($objects) : $objects, $flush);
+        $this->flushObjects($objects, $flush);
     }
 
     /**
      * Flush managed objects.
      *
-     * @param object|object[] $objects
-     * @param bool            $flush
+     * @param object|object[]|\Traversable $objects
+     * @param bool                         $flush
      */
     protected function flushObjects($objects, bool $flush)
     {
+        if ($objects instanceof \Traversable) {
+            $objects = iterator_to_array($objects);
+        }
+
         if ($flush || $this->autoFlush) {
             $this->getManager()->flush($objects);
         }